Remove ClassSupportsIClassX which always returns true - #131683
Open
elinor-fung with Copilot wants to merge 2 commits into
Open
Remove ClassSupportsIClassX which always returns true#131683elinor-fung with Copilot wants to merge 2 commits into
elinor-fung with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
elinor-fung
July 31, 2026 23:10
View session
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
AaronRobinsonMSFT
approved these changes
Jul 31, 2026
elinor-fung
marked this pull request as ready for review
July 31, 2026 23:24
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
@copilot can we remove enum_SupportsIClassX and adjust the code paths that check it to take the "is set" branch if it's set unconditionally? |
Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
Contributor
Author
Done in commit that follows on this PR. Removed
Note This response was generated by GitHub Copilot. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassSupportsIClassXwas a stub that unconditionally returnedTRUE, making all call sites either dead code or no-ops. Removes the function and simplifies the call sites.interoputil.cpp/interoputil.h: DeleteClassSupportsIClassXfunction and declarationcomcallablewrapper.cpp: Remove always-trueif (ClassSupportsIClassX(pMT))guard;enum_SupportsIClassXis set unconditionallyclass.cpp: Remove always-falseif (!ClassSupportsIClassX(this)) return clsIfNone;dead code path inGetComClassInterfaceType